testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

fix(wait): inconsistent behaviour

Open stevenh opened this issue 1 year ago • 1 comments

Use IsHost method instead of comparison with string.

Remove unnecessary if nil check on slice length.

Remove unnecessary fmt.Sprintf on non format string.

Refactor HostPortStrategy and HTTPStrategy tests to use generated mocks and a builder to increase test coverage and fix the behavioural inconsistencies identified.

Replicate WithForcedIPv4LocalHost from HTTPStrategy to HostPortStrategy to ensure feature parity.

Refactor wait host port lookups to use common functions so that HostPortStrategy and HTTPStrategy don't have hard to find logic differences in edge case handling. This includes consistent target checks, exposed port waiting for specified and unspecified paths.

Improve error checking and wrapping.

Extract wait tests into wait_test package.

Fix ForLog to allow checking across multiple log reads and ensure that the container is valid.

Fix ForLog to return as soon as context is cancelled instead of waiting for poll to expire.

Refactor ForLog to allow line by line checks which is quicker in the common case.

stevenh avatar Sep 08 '24 20:09 stevenh

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit 326ddfa9d5db820b5ad39bace67505bf651f1bb7
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66e014eced041800081bd8ea
Deploy Preview https://deploy-preview-2773--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 08 '24 20:09 netlify[bot]