testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

Don't re-use reaper if it failed to initialize

Open kernle32dll opened this issue 4 years ago • 1 comments

If the reaper fails to initialize, it leaves testcontainers in a broken state. To be precise, the Endpoint variable is never properly initialized, which causes subsequent usages of testcontainers to fail with failed to create container: connecting to reaper failed: Connecting to Ryuk on failed: dial tcp: missing address.

kernle32dll avatar Oct 11 '20 18:10 kernle32dll

@kernle32dll are you still interested in this PR? If not, I'd like to label it as hacktoberfest in case anybody is willing to help here.

mdelapenya avatar Oct 03 '22 11:10 mdelapenya

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit c0f2febdb869c585c4e3872c9bf695aa2cf1ba66
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/63d01ff03c73cf00085c0d34
Deploy Preview https://deploy-preview-258--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jan 24 '23 18:01 netlify[bot]

With merging https://github.com/testcontainers/testcontainers-go/pull/782, I believe this PR became obsolete and can be closed?

mdonkers avatar Jan 31 '23 14:01 mdonkers

I believe so. I'm closing it but feel free to reopen if it persists, thanks!

mdelapenya avatar Jan 31 '23 14:01 mdelapenya