testcontainers-go
testcontainers-go copied to clipboard
testcontainers
Make the replica set name configurable
What does this PR do?
This PR makes the replica set name configurable, instead of using a predefined name rs.
Why is it important?
A MongoDB replicaset name is a configurable option so I wanted to align test containers with that.
Related issues
None
Deploy Preview for testcontainers-go ready!
| Name | Link |
|---|---|
| Latest commit | adad66c063fd4c889ba5881fdb8e2b410810bacb |
| Latest deploy log | https://app.netlify.com/sites/testcontainers-go/deploys/666bf87ad3e89000085f4a60 |
| Deploy Preview | https://deploy-preview-2538--testcontainers-go.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @shubhamrajvanshi could you take a look at this comment https://github.com/testcontainers/testcontainers-go/pull/2469#discussion_r1593978391?
We discussed about it when adding the replica set option. I'm not blocking this, but giving you more context. WDYT?
Thanks @mdelapenya for pushing the relevant changes and getting this merged