testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE

Open hanapedia opened this issue 1 year ago • 1 comments

What does this PR do?

Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE to align with other testcontainers projects.

Why is it important?

The changes in this PR will align how to override the host of the docker daemon where the container port is exposed with other testcontainers projects and the current testcontainers-go documentation.

In other testcontainers projects, TESTCONTAINERS_HOST_OVERRIDE environment variable is used to override host of the docker daemon where the container port is exposed. testcontainers-go mentions this environment variable in the documentation but it is currently not implemented. Instead, testcontainers-go uses TC_HOST, which is the old envrionment variable used in other projects for the same purpose.

Related issues

  • Relates #1373
  • Closes #2209
  • Relates #2522

Follow-ups

The changes in this PR will deprecate TC_HOST environment variable.

hanapedia avatar May 08 '24 15:05 hanapedia

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit 21280a20700c296ece38dc715bb633fb91a3e107
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/667e9faff3927f0008052a8f
Deploy Preview https://deploy-preview-2536--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 08 '24 15:05 netlify[bot]