testcontainers-go
testcontainers-go copied to clipboard
testcontainers
feat:SSL for postgres
What does this PR do?
Enables SSL for postgres
The main thing to recognize when reviewing this is that the secret material must be owned by the postgres user. The docker file copy api doesn't allowfor setting a user when copying. The only way I could think was to take wrap the entrypoint script with one that does what we want.
Why is it important?
User ran into issue trying to use SSL. It's not obviously supported (able) due to file permissions.
Related issues
Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it.
- Closes #2404
How to test this PR
Unit tests will work when complete.
Deploy Preview for testcontainers-go ready!
| Name | Link |
|---|---|
| Latest commit | 53d9a1ac70e954800b79f24feb2ee407570f5db5 |
| Latest deploy log | https://app.netlify.com/sites/testcontainers-go/deploys/662bd087d8a39a0008d6b1c4 |
| Deploy Preview | https://deploy-preview-2473--testcontainers-go.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@bearrito could you please take a look at https://github.com/testcontainers/testcontainers-go/pull/2478? I'm adding helper code to deal with TLS certificates in order to simplify the story for the client code. Wdyt?
@mdelapenya That makes a lot of sense. Much cleaner.
Do you want me to wait until that's done then base this on top of that?
@bearrito I went ahead and extracted the TLS cert generation to a separate go package, which makes more sense: https://github.com/mdelapenya/tlscert
Please take a look and use it as you need here!
@mdelapenya Update so that the entrypoint is coupled with the ssl settings. What about doing something similar for the conf file?
@mdelapenya Anything else on this? I'm going on holiday and am closing out my open pr's