testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

fix(cockroachdb): Fixes cockroachdb wait strategy handling

Open bearrito opened this issue 1 year ago • 2 comments

What does this PR do?

Fixes wait strategy handling. Previously cockroachdb was overwriting wait strategies.

Why is it important?

Custom wait strategies were not being respected

Related issues

  • Closes #2453

How to test this PR

I added tests. There looks to be some form of connection logic in the SQL strategy. This has to be merged into the user provided strategy otherwise you will timeout.

bearrito avatar Mar 30 '24 15:03 bearrito

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit 0c35c64bbce8d62c7ed3f73110ca9fce5c50d5de
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66680369e868c20008a78c9c
Deploy Preview https://deploy-preview-2456--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 30 '24 15:03 netlify[bot]

@mdelapenya Is this good to go, the last failing test were unrelated

bearrito avatar Apr 13 '24 15:04 bearrito

@mdelapenya Anything else on this?

bearrito avatar May 23 '24 13:05 bearrito

@mdelapenya I reverted to always honor the default strategy. I don't think can do much more with cockroach, namely because how it's doing it's own thing with the addWaitingFor and addingEnvs

bearrito avatar Jun 10 '24 18:06 bearrito