testcontainers-go
testcontainers-go copied to clipboard
fix(cockroachdb): Fixes cockroachdb wait strategy handling
What does this PR do?
Fixes wait strategy handling. Previously cockroachdb was overwriting wait strategies.
Why is it important?
Custom wait strategies were not being respected
Related issues
- Closes #2453
How to test this PR
I added tests.
There looks to be some form of connection logic in the SQL strategy. This has to be merged into the user provided strategy otherwise you will timeout.
Deploy Preview for testcontainers-go ready!
| Name | Link |
|---|---|
| Latest commit | 0c35c64bbce8d62c7ed3f73110ca9fce5c50d5de |
| Latest deploy log | https://app.netlify.com/sites/testcontainers-go/deploys/66680369e868c20008a78c9c |
| Deploy Preview | https://deploy-preview-2456--testcontainers-go.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@mdelapenya Is this good to go, the last failing test were unrelated
@mdelapenya Anything else on this?
@mdelapenya I reverted to always honor the default strategy. I don't think can do much more with cockroach, namely because how it's doing it's own thing with the addWaitingFor and addingEnvs