testcontainers-go
testcontainers-go copied to clipboard
feat(modules.mongodb): setup mongodb replicaset
What does this PR do?
Fix issue #2138
Why is it important?
Related issues
Deploy Preview for testcontainers-go ready!
| Name | Link |
|---|---|
| Latest commit | 028c5c5cf8258d6661c5d104111838e6a8f131b2 |
| Latest deploy log | https://app.netlify.com/sites/testcontainers-go/deploys/65b214c8ce225b0008c85662 |
| Deploy Preview | https://deploy-preview-2139--testcontainers-go.netlify.app/modules/mongodb |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks for your contribution, @trungdlp-wolffun. Currently, the module support standalone mode by default. Adding ReplicaSet is really nice, however, IMO, this should be an opt-in feature. In the future, sharding can be added as well as a opt-in feature too.
Please, do not forget to add proper test.
Hi @trungdlp-wolffun I think https://github.com/testcontainers/testcontainers-go/pull/2469 has better readability so I think we are going to build on top of that. This PR will be closed once that one is merged.
I'm sorry if the review took so long 🙏
Thanks!