testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

feat: enable access to kafka using container hostname

Open sermio-te opened this issue 1 year ago • 1 comments

What does this PR do?

This PR applies a fix to the entrypoint script template variables used in the kafka module container in order to make kafka accessible to other containers in the same network.

Why is it important?

Kafka container created by the kafka module needs to be exposed to the other containers in the same network.

Related issues

  • No

How to test this PR

After starting a Kafka container using the Kafka module, the KAFKA_ADVERTISED_LISTENERS should contain the endpoint of the container host.

E.g. For Kafka container name set to broker, the /usr/sbin/testcontainers_start.sh script should contain the following value:

export KAFKA_ADVERTISED_LISTENERS=PLAINTEXT://localhost:51702,BROKER://broker:9092

sermio-te avatar Oct 20 '23 09:10 sermio-te

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit 4adc310e936c8ad56912354a4841a1d712537031
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/653247d859b57000084c2ed8
Deploy Preview https://deploy-preview-1786--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 20 '23 09:10 netlify[bot]