testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

feat: add module to support InfluxDB v1.x

Open JJCinAZ opened this issue 2 years ago • 8 comments

What does this PR do?

Added support for InfluxDB v1.x containers.

Why is it important?

Enhanced testcontainers-go project.

JJCinAZ avatar Sep 30 '23 22:09 JJCinAZ

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit fe4c8874fd123b1c92cce6026e60f6442b982cdc
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65fd9aa59fd8ff0008f5e337
Deploy Preview https://deploy-preview-1703--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 30 '23 22:09 netlify[bot]

Hi @JJCinAZ ,

Have you read this page ?

Some expected configurations configured by modulegen seems to be missing from your PR.

mmorel-35 avatar Oct 01 '23 06:10 mmorel-35

Hey @JJCinAZ I'd recommend you using our module generator to bootstrap the module, as it will generate the right files also updating the descriptors files (GH actions, mkdocs, etc) 🙏

mdelapenya avatar Oct 09 '23 15:10 mdelapenya

@mdelapenya I think that InfluxDB v2 is an abandoned product in so far as Influx has completely changed for v3 and abandoned the Flux language they introduced in v2. At this point, I have little faith they will actually have an OSS v3, so many of us are stuck at v1.8 until we migrate completely. If someone else has need for good v2 support, we can revisit how to make that happen.

JJCinAZ avatar Oct 17 '23 16:10 JJCinAZ

If someone else has need for good v2 support, we can revisit how to make that happen.

So your intention is to create an InfluxDB v1-only module, right?

mdelapenya avatar Oct 18 '23 07:10 mdelapenya

Yes, v1 only.

On Oct 18, 2023, at 12:54 AM, Manuel de la Peña @.***> wrote:

If someone else has need for good v2 support, we can revisit how to make that happen.

So your intention is to create an InfluxDB v1-only module, right?

— Reply to this email directly, view it on GitHubhttps://github.com/testcontainers/testcontainers-go/pull/1703#issuecomment-1767888346, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACMBST47SPIB6OSNRFYJBCDX76DKXAVCNFSM6AAAAAA5N2MQBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXHA4DQMZUGY. You are receiving this because you were mentioned.Message ID: @.***>

JJCinAZ avatar Oct 18 '23 14:10 JJCinAZ

@JJCinAZ sorry for not going on this PR since October 🙏 For that reason I did not want to cause you more trouble and went ahead and added some commits on top to update the code to the current state of the main branch.

If possible, I'd like you to review it and give your 👍 👎

Thanks!

mdelapenya avatar Mar 13 '24 13:03 mdelapenya

@mdelapenya Thanks for adding the extra commits. I'm not familiar with the documentation system you use and do not use external linters in my Go projects, so thanks for cleaning those up.

JJCinAZ avatar Mar 13 '24 21:03 JJCinAZ