testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

[Enhancement]: Some ideas for testcontainers-go

Open mmorel-35 opened this issue 2 years ago • 6 comments

Proposal

There are several ideas I can see concerning testcontainers-go, some concerning modulegen, some concerning the CI/CD.

Modulegen

  • [x] ~~extract mkdocs example.md file generation in /internal/mkdocs~~ #1543
  • [x] ~~extract Makefile file generation in /internal/make~~ #1537
  • [x] ~~extract example.go and example_test.go file generation in /internal/module~~ #1539
  • [x] ~~extract go.mod file generation in /internal/module and replace html/template with golang.org/x/mod/modfile to directly read from main go.mod~~ #1539
  • [ ] Replace templates functions with Example attributes
  • [x] ~~use github.com/spf13/cobra to handle the commands~~ #1550

CI/CD

  • [x] ~~Provide code coverage to sonarcloud (starting with main module)~~ #1518
  • [ ] ~~Generate sonar-project.properties per module/example ?~~
  • [ ] ~~Change dependabot updates schedule interval to "weekly" to address updates more frequently so it doesn't become an epic task every month ?~~
  • [ ] ~~Move Image of the example/module to a Dockerfile to be able to receive updates from dependabot ?~~
  • [ ] trigger a go mod tidy on every module depending on the main one when it is modified

I'm much more focused on modulegen for the moment

mmorel-35 avatar Aug 25 '23 09:08 mmorel-35

Change dependabot updates schedule interval to "weekly" to address updates more frequently so it doesn't become an epic task every month ?

We already had that schedule, and there were lots of updates, exhausting the free tier of our GH actions workers across the entire testcontainers organisation.

mdelapenya avatar Aug 25 '23 10:08 mdelapenya

I guess that at that time there was no groups for the updates. Would it helps smooth the process? Another option would be to replace dependabot with renovate.

mmorel-35 avatar Aug 25 '23 11:08 mmorel-35

Move Image of the example/module to a Dockerfile to be able to receive updates from dependabot ?

Regarding this, I'd say no, as we want to keep modules stable, at least until we have a real support matrix (which we do not have). Also moving to a Dockerfile-based module will force users to build the image again and again.

Just in case, I'm exploring updatecli for certain updates

mdelapenya avatar Aug 31 '23 09:08 mdelapenya