testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

First implementation of DockerRegitry module

Open davidesalerno opened this issue 2 years ago • 7 comments

What does this PR do?

This PR is adding the new Docker Registry module. This module is wrapping the registry image and it will be useful for those who needs to interact with a container registry to check if images are pushed or not after a build (i.e. local integration test of projects like kaniko or buildah).

davidesalerno avatar May 10 '23 13:05 davidesalerno

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit 8e54e79e5d856f0a56357110e456545626d2af1c
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/649c8e523e6ec70008b63a90
Deploy Preview https://deploy-preview-1165--testcontainers-go.netlify.app/modules/dockerregistry
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 10 '23 13:05 netlify[bot]

Not to mention that we could eventually merge this PR at this state, without the authentication, and create a follow-up PR with that work. At the end of the day, the module won't be available until the next release

mdelapenya avatar May 10 '23 13:05 mdelapenya

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 10 '23 13:05 sonarqubecloud[bot]

Hi @davidesalerno did you take a look at my comment here https://github.com/testcontainers/testcontainers-go/pull/1165#pullrequestreview-1420650610?

mdelapenya avatar Jun 13 '23 08:06 mdelapenya

Hi @davidesalerno did you take a look at my comment here #1165 (review)?

Yes, I've just added a customizer to support an authenticated registry but I'm having some issue in testing it due to issu #279.

Could you help me in test that is working making this unit test working?

davidesalerno avatar Jun 13 '23 13:06 davidesalerno

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
11.0% 11.0% Duplication

sonarqubecloud[bot] avatar Jun 28 '23 19:06 sonarqubecloud[bot]

@davidesalerno we have sent https://github.com/testcontainers/testcontainers-go/pull/2341 creating a module for the docker registry. It supersedes this one, so I marked it to close this one.

I'd thank you a lot if you could take a look to that PR and come with your feedback, so it should cover your use case 🙏

Cheers!

mdelapenya avatar Mar 11 '24 20:03 mdelapenya