testcontainers-dotnet
testcontainers-dotnet copied to clipboard
testcontainers
feat(#540): Support for registry auth credentials from env var DOCKER_AUTH_CONFIG
@HofmeisterAn I don't completely understand the purpose of these classes (CustomConfiguration, EnvironmentConfiguration and PropertiesFileConfiguration) in case of DockerRegistryAuthenticationProvider logic, but I made some changes, please review them and let me know if I misunderstood anything
I reviewed and applied your suggestions, but with small change:
GetDefaultDockerAuthConfig() now returns nullable value because we want to check for default docker config even if dockerConfigFile doesn't exist (else if block)
I can test this on my local machine and CI server if you pack it into the NuGet
@HofmeisterAn I confirm that it works locally with .docker directory and on CI/CD server with DOCKER_AUTH_CONFIG env variable. I think we can merge this to develop and pack into release tag
By the way, it looks like I tested not the same code as this PR produces. That's why we have conflict
Oh, I see, you made some further changes. Do you want me to repeat them in my code, or you will just close the PR?
Do you want me to repeat them in my code, or you will just close the PR?
No, not necessary. I merged and pushed all changes to develop already. You tested the right version. Thanks again.
Hi @HofmeisterAn Please let me know when you plan to publish the release version containing this feature? It's quite strange to use the beta version of package in production environment :)
No ETA yet. I'd like to add the custom HTTP headers to the next version first.