testcontainers-dotnet icon indicating copy to clipboard operation
testcontainers-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

Improve error reporting when loading the Docker configuration file

Open 0xced opened this issue 1 year ago • 1 comments

What does this PR do?

This pull request improves error handling while reading the Docker context configuration file. It throws a new DockerConfigurationException instead of silently failing.

Also, since GetCurrentEndpoint() can't return null anymore there's no need to try the default GetSocketPathFromHomeDesktopDir() and GetSocketPathFromHomeRunDir() socket paths.

Why is it important?

Silently returning null instead of throwing proper exceptions makes it harder to diagnose issues.

Related issues

  • Relates #1235

How to test this PR

The DockerConfigTests were updated and a new ThrowsWhenDockerConfigEndpointNotFound test was added.

0xced avatar Sep 19 '24 09:09 0xced

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 65e6a7253335b72e1fcbe2ddc8dc3048d1b3510f
Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/68260199d6165900089055d8
Deploy Preview https://deploy-preview-1263--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Sep 19 '24 09:09 netlify[bot]