testcontainers-dotnet icon indicating copy to clipboard operation
testcontainers-dotnet copied to clipboard

Only handle the time issue in the affcted Pulsar versions and Update default Pulsar image

Open entvex opened this issue 1 year ago • 2 comments

What does this PR do?

This commit changes the default Pulsar image from version 3.2.3 to 3.0.6. Additionally, it updates the logic to specifically handle image version v3.2.0-3 and 3.3.0 due to known issues in certain versions. As it is fixed in 3.2.4 and 3.3.1. Please see https://pulsar.apache.org/release-notes/

Why is it important?

Right now the fix is applied to the latest tag. Which can cause issues. If the user decides to use the latest tag or use an Apache Pulsar version with the issue resolved.

How to test this PR

Ran all the tests

entvex avatar Aug 12 '24 12:08 entvex

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 5690b5c183b3ee1326cbca9850bb0c8f295eb8a8
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/66d721c77ebe9d000852f384
Deploy Preview https://deploy-preview-1232--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 12 '24 12:08 netlify[bot]

I have made the changes and if it all looks good to you. Then it is ready to merge 😄

entvex avatar Aug 23 '24 08:08 entvex

Thanks for the PR. Could you please remove the unnecessary changes (such as whitespaces) to keep the PR changes to a bare minimum?

Sure i'll try 👍

entvex avatar Aug 31 '24 10:08 entvex

I have removed the unnecessary white spaces. Sorry it took so long @HofmeisterAn

entvex avatar Sep 03 '24 11:09 entvex