action icon indicating copy to clipboard operation
action copied to clipboard

Links to https://svg.test-summary.com not working

Open severikupari1 opened this issue 10 months ago • 11 comments

In build summary used icons are not showing up because the links points to non working website.

Image

Image

https://svg.test-summary.com/dashboard.svg?p=409&f=3&s=23

severikupari1 avatar Feb 13 '25 13:02 severikupari1

Hey @ethomson, did you forget to prolong the registration of test-summary.com?

webknjaz avatar Feb 17 '25 01:02 webknjaz

Maybe a stupid question, but why is the svg not embedded as a svg tag instead of pulling the image from a obscure website?

LjungErik avatar Feb 19 '25 11:02 LjungErik

@LjungErik I think that GH Markdown doesn't allow that.

webknjaz avatar Feb 19 '25 18:02 webknjaz

No but I must have broken something! I'll take a look.

ethomson avatar Feb 19 '25 19:02 ethomson

Thanks, folks, sorry I missed the ping initially, my notifications are a bit of a mess right now. 😅

I had broken DNS, and I've repaired it. It may take a little bit to propagate through caches. Thanks again for the ping!

ethomson avatar Feb 19 '25 20:02 ethomson

Thank you for fixing this! 💯

severikupari1 avatar Feb 19 '25 20:02 severikupari1

@webknjaz @ethomson Can't we just host the SVGs on Github directly instead of having a external dependency on a website

LjungErik avatar Feb 24 '25 13:02 LjungErik

@LjungErik that SVG isn't static, in contains dynamically filled out data.

webknjaz avatar Feb 24 '25 14:02 webknjaz

Right; I'm running compute to generate those svgs. 😀

ethomson avatar Feb 24 '25 15:02 ethomson

But also, I think that you can't embed SVGs inside GitHub-flavored Markdown? I admit that I haven't tried it in a few years, though, so maybe the state of the art has changed.

ethomson avatar Feb 24 '25 15:02 ethomson

I think it'd work if one of these things was true: either a static SVG (GH Pages would handle it) or the ability to embed SVG into Markdown. Referencing standalone SVG files got fixed back in 2022: https://github.blog/changelog/2022-01-21-allow-to-upload-svg-files-to-markdown/. But I don't think the MD sanitizer changed since.

webknjaz avatar Feb 24 '25 16:02 webknjaz