kitchen-vagrant icon indicating copy to clipboard operation
kitchen-vagrant copied to clipboard

feat(tart provider): Consolidate VM name logic and add vendor to .gitignore

Open Copilot opened this issue 1 month ago • 2 comments

This PR implements support for the tart provider in kitchen-vagrant by consolidating the VM name setting logic, addressing the review feedback from PR #503.

Changes Made

  • Consolidated case blocks: Merged two separate case config[:provider] blocks into a single one for setting p.name in templates/Vagrantfile.erb, improving code maintainability
  • Tart provider support: Added tart provider with VM naming that excludes the UUID suffix (format: kitchen-<root>-<instance> instead of kitchen-<root>-<instance>-<uuid>)
  • Test coverage: Added test case in spec/kitchen/driver/vagrant_spec.rb for the tart provider VM naming behavior
  • .gitignore update: Added vendor directory to prevent bundler dependencies from being committed to the repository

Background

The tart provider (https://github.com/letiemble/vagrant-tart) for Vagrant enables Test Kitchen to work with tart VMs (https://github.com/cirruslabs/tart). This PR follows the review feedback suggesting to consolidate duplicate case statements rather than having separate blocks for VM name configuration.

Testing

  • ✅ All 225 tests pass, including new tart provider test
  • ✅ Verified tart provider VM name is set correctly without UUID
  • ✅ Verified virtualbox provider behavior remains unchanged

The changes are minimal and focused, following existing code patterns in the repository.

Original prompt

Read this pull request: https://github.com/test-kitchen/kitchen-vagrant/pull/503

rework the logic.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot avatar Nov 11 '25 11:11 Copilot

@copilot git ignore the vendor directory and try again!

damacus avatar Nov 11 '25 11:11 damacus

@copilot git ignore the vendor directory and try again!

Added vendor to .gitignore in commit 2fbf774.

Copilot avatar Nov 11 '25 11:11 Copilot