kitchen-digitalocean icon indicating copy to clipboard operation
kitchen-digitalocean copied to clipboard

Plans for moving from legacy driver?

Open nacc opened this issue 4 years ago • 4 comments

:speaking_head: Foreword

Thank for taking the time to fill this feature request fully. Without it we may not be able to , and the issue may be closed without resolution.

:frowning_person: Problem Statement

In trying to work through some hairy chef-internal changes that I needed to stage, I was hoping to leverage some provisioner: variables (e.g., retry_on_exit_code). However, because kitchen-digitalocean is a "legacy" Driver (inherits from SSHBase, aiui), the provisioner variables aren't actually used, because the driver does the converge (over ssh) rather than the provisioner.

:grey_question: Possible Solution

I am not entirely sure what is necessary to not be a legacy Driver, but I'm happy to invest time to do the code changes. I want to find out, first, though, if there is interest in that being done and if such a PR would be acceptable.

:arrow_heading_up: Describe alternatives you've considered

I suppose an alternative would be to add support for those variables to the kitchen-digitalocean Driver directly, but that seems like the wrong direction if deprecation of legacy Drivers is really the intention upstream.

nacc avatar Jan 14 '21 16:01 nacc

@tas50 any thoughts on this?

marcparadise avatar Jun 23 '21 17:06 marcparadise

One of the tasks for the new team is to cleanup internal implementations of all the drives so this is on the list.

tas50 avatar Jun 23 '21 17:06 tas50

Ty!

nacc avatar Jun 23 '21 18:06 nacc

@tas50 do you have any links to what is needed to update the implementations?

nacc avatar Sep 22 '21 17:09 nacc