Helmut K. C. Tessarek

Results 516 comments of Helmut K. C. Tessarek

@dani-garcia @BlackDex can you start the workflows?

@zUnixorn unfortunately the pipeline has clippy and format issues. I can fix them and push a commit, if you give me access to your branch.

Yep, should work. I'll see in a few minutes. If not, I'll just open a PR in your repo.

Yep, worked. But I had to rebase to solve the conflict. Now we need @dani-garcia or @BlackDex to restart the workflows again.

I don't understand. The CI pipelines were successful. Or are you telling me they are for show? I have compiled vw on this PR branch locally (Linux and macOS) as...

@BlackDex in that case wouldn't it make sense to add this to the pipeline as a target matrix? Or is failing those platforms not a reason not to merge? P.S.:...

@dani-garcia I think this one needs one last workflow approval. With 0.5.2 building for arm64, armv7 and armv6 has been solved. The requested changes have also been implemented.

This looks good to me. Is there still something missing? Merging this will pave the way for #5929

I only tested from the current version to this one. I'm not using docker/podman, so testing old rust binaries can be tricky (even compiling older code with new toolchains can...