trajopt icon indicating copy to clipboard operation
trajopt copied to clipboard

Discrete collision check setting

Open rjoomen opened this issue 1 year ago • 3 comments

Shouldn't is_continuous be false here, as it is the LVSDiscreteCollisionEvaluator?

rjoomen avatar Nov 20 '23 14:11 rjoomen

Otherwise LVSContinuousCollisionEvaluator::CalcCollisionData() and LVSDiscreteCollisionEvaluator::CalcCollisionData() are exactly the same.

rjoomen avatar Nov 20 '23 15:11 rjoomen

It needs to be set to true, it is still considered continues from a trajopt perspective even though it is using a discrete contact checker because it is integrating collision data along the path between two state.

Levi-Armstrong avatar Nov 20 '23 19:11 Levi-Armstrong

What do you think about moving CalcCollisionData() to parent class ContinuousCollisionEvaluator then?

rjoomen avatar Nov 21 '23 07:11 rjoomen