trajopt icon indicating copy to clipboard operation
trajopt copied to clipboard

Published 20 hours ago • verified publisher icon tesseract-robotics

refactored test suite

Open rkliman opened this issue 5 years ago • 8 comments

Creates a standalone test suite package for all optimizers. BasicOptimization is currently a work in progress as it will not work with OSQP_eigen. However, it does work with ifopt as well as PaGMO which is another branch coming soon

rkliman avatar Jul 13 '20 21:07 rkliman

Also, you'll want to run clang format on it so that CI will pass. There is a bash script in the repo that does that.

mpowelson avatar Jul 13 '20 21:07 mpowelson

fixed a bunch of issues, new pull request incoming

rkliman avatar Jul 15 '20 16:07 rkliman

@rkliman You don't have to create a new pull request. Just push to this branch and it will update.

mpowelson avatar Jul 15 '20 16:07 mpowelson

It is close, we just need to restructure it a bit.

mpowelson avatar Jul 15 '20 21:07 mpowelson

@rkliman I see that some of mpowelson requested changes have not been marked resolved. Did these get resolve?

Levi-Armstrong avatar Jul 31 '20 17:07 Levi-Armstrong

@Levi-Armstrong Yes, they have been resolved

rkliman avatar Jul 31 '20 17:07 rkliman

@mpowelson You good with merging this?

Levi-Armstrong avatar Jul 31 '20 21:07 Levi-Armstrong

I have not reviewed it again, but if you think it looks ok that is fine.

It looks like this includes the pagmo interface as well. Is that potentially breaking for anyone? Ie, is pagmo released on all our target systems? I haven't checked. Also, importantly pagmo is LGPL not GPL.

mpowelson avatar Aug 01 '20 03:08 mpowelson