tesseract icon indicating copy to clipboard operation
tesseract copied to clipboard

Remove scale from visualization marker base class

Open marip8 opened this issue 3 years ago • 0 comments

The tesseract_visualization::Marker base class currently has a scale_ parameter that seems to control the size of some markers.

https://github.com/ros-industrial-consortium/tesseract/blob/3857b5252b9fc1fb9de6de976ac6733799fa476e/tesseract_visualization/include/tesseract_visualization/markers/marker.h#L139-L145

However, most markers (tool path, axis, arrow) have their own parameters for defining how large the objects are. In the case of the tool path marker, the tool path specific scale parameter, not the base class scale, is used to determine how large the waypoint axes are (see here). It seems like the size of an object should be a property of the visualization implementation, so I would propose removing the scale_ parameter from the base class. @Levi-Armstrong is there a case for not removing it from the base class?

marip8 avatar Jun 23 '21 18:06 marip8