kira icon indicating copy to clipboard operation
kira copied to clipboard

`<MockBackend as Backend>::Error` should be a real error type

Open a1phyr opened this issue 2 years ago • 4 comments
trafficstars

Currently, <MockBackend as Backend>::Error is () so it cannot be converted to Box<dyn std::error::Error>.

Using std::convert::Infallible or a standalone type that implement std::error::Error would be more convenient.

a1phyr avatar May 22 '23 15:05 a1phyr

Indeed. I came across this issue when trying to get the doc tests passing when the cpal feature isn't enabled. I ultimately didn't bother fixing it because there were other issues I would have to fix too, and it wasn't worth it. Are you finding this to be an issue outside of running tests?

tesselode avatar May 23 '23 01:05 tesselode

I came across this issue in the exact same situation. I added "cpal" feature in my dev-dependencies and it worked. It may still be worth fixing, though.

a1phyr avatar May 29 '23 13:05 a1phyr

Are you making a library based on Kira?

tesselode avatar May 29 '23 14:05 tesselode

Yes I was making asset_manager-kira, an integration with assets_manager

a1phyr avatar Aug 10 '23 17:08 a1phyr