egui-tetra icon indicating copy to clipboard operation
egui-tetra copied to clipboard

Responsive maintainer?

Open TimerErTim opened this issue 2 years ago • 6 comments

Hello, I just wanted to know whither or not the maintainer of this repo is responding to PRs. I want to update this project to be compatible with tetra 0.7.0, so @tesselode can publish a new release of this crate.

If he isn't responding to the PR, I would upload the crate myself by forking it.

TimerErTim avatar Sep 10 '22 11:09 TimerErTim

Hi,

I do see notifications, although admittedly I haven't been as responsive as I would like. @devmeat already made a PR to update tetra and egui, but they closed it before I merged it in. I could still merge it, but I'm not sure if there's some reason they don't want me to merge it.

If you do make a PR, just nag me here or in the rust gamedev discord until I merge it in.

tesselode avatar Sep 11 '22 17:09 tesselode

@tesselode @TimerErTim The original PR fixes compatibility issues with Tetra 0.7. However, I found an issue with images looking corrupted. Sadly I haven't had time to look into it, and closed it just in case this is related to my changes.

devmeat avatar Sep 12 '22 09:09 devmeat

I opened this issue as I thought there occurred more compatibility issues with tetra 0.7.0 compared to pre releases.
On my local environment it seemed your (@devmeat ) PR introduced an issue with tetra 0.7.0 (not alpha) regarding incompatible but equally identified structs. That however was caused by my local configuration and was not caused by your update. I have now fixed it.

If it is of any use for you, I have not observed image corruption with tetra 0.7.0. However I have not done any testing for that problem. I could do that though, if it benefits you.

TimerErTim avatar Sep 12 '22 10:09 TimerErTim

@TimerErTim I've reopened the PR: https://github.com/tesselode/egui-tetra/pull/3

If it is of any use for you, I have not observed image corruption with tetra 0.7.0. However I have not done any testing for that problem. I could do that though, if it benefits you.

Yes, please. It could be just my setup, but just want to be sure.

devmeat avatar Sep 12 '22 15:09 devmeat

I'll try to take a look soon, but @devmeat are you able to post an example project that demonstrates the image corruption?

tesselode avatar Sep 13 '22 12:09 tesselode

@tesselode Unfortunately, I don't have anything to post as an example at this point in time. I had to port my game due to Tetra not being maintained anymore.

devmeat avatar Sep 25 '22 20:09 devmeat