react-native-camera-kit icon indicating copy to clipboard operation
react-native-camera-kit copied to clipboard

Published 20 hours ago • verified publisher icon teslamotors

fix `scanBarcode` property not working in iOS issue

Open phlpsong opened this issue 3 years ago • 2 comments

Summary

This PR will fix #476

For iOS , there's no matching property defined in native, update scanBarcode property in component will not working.

How did you test this change?

  1. Assign scanBarcode={false} to CameraScreen in example project.
  2. Scan barcode, check whether navigate to result screen.

phlpsong avatar Jul 14 '22 13:07 phlpsong

@scarlac Very appreciate if you could review this PR.

phlpsong avatar Jul 31 '22 13:07 phlpsong

@scarlac Thanks for your comment! Remove the event handler in JS maybe works, but this scanBarCode prop working well on Android platform but not in iOS, The inconsistent may need extra workarounds in iOS. I think this will keep consistency with both platforms and let this prop working as expected.

I think I could remove the delegate after this prop changes if you would like. Appreciate and looking forward to your further comments.

phlpsong avatar Aug 11 '22 05:08 phlpsong