react-native-camera-kit
react-native-camera-kit copied to clipboard
fix orientation problem, fix scanner problem
Summary
- For an iPad app, device rotation is an ordinary thing. In our app, we support portrait and landscape. When the device rotates, the videoOrientation is not changed.
What is included in the PR:
- The captured content is not rotated as the device rotate, fixed.
- The frame of the scanner view is not updated when the device rotates, fixed.
How did you test this change?
- use a physical device, both iPad and iPhone
This looks interesting. Are you trying to make rounded corners? Perhaps there is a better way of doing that, like view.layer.cornerRadius
or something?
Please provide a video of the finished results when you're done.
The bug demo:
https://user-images.githubusercontent.com/2476434/162385534-09fc7a88-113b-4f64-b0b6-11d4357a73a0.mp4
The bug fix demo:
https://user-images.githubusercontent.com/2476434/162385558-8be6b588-39dc-45e4-a58f-6aa907492aab.mp4
Close it in favor of #542