react-native-camera-kit icon indicating copy to clipboard operation
react-native-camera-kit copied to clipboard

fix orientation problem, fix scanner problem

Open summer-wu opened this issue 2 years ago • 2 comments

Summary

  • For an iPad app, device rotation is an ordinary thing. In our app, we support portrait and landscape. When the device rotates, the videoOrientation is not changed.

What is included in the PR:

  • The captured content is not rotated as the device rotate, fixed.
  • The frame of the scanner view is not updated when the device rotates, fixed.

How did you test this change?

  • use a physical device, both iPad and iPhone

summer-wu avatar Apr 07 '22 13:04 summer-wu

This looks interesting. Are you trying to make rounded corners? Perhaps there is a better way of doing that, like view.layer.cornerRadius or something? Please provide a video of the finished results when you're done.

scarlac avatar Apr 07 '22 16:04 scarlac

The bug demo:

https://user-images.githubusercontent.com/2476434/162385534-09fc7a88-113b-4f64-b0b6-11d4357a73a0.mp4

The bug fix demo:

https://user-images.githubusercontent.com/2476434/162385558-8be6b588-39dc-45e4-a58f-6aa907492aab.mp4

summer-wu avatar Apr 08 '22 07:04 summer-wu

Close it in favor of #542

summer-wu avatar May 19 '23 08:05 summer-wu