teslamate icon indicating copy to clipboard operation
teslamate copied to clipboard

Drive Graph/Map correlation broken.

Open LelandSindt opened this issue 1 year ago • 11 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

What happened?

As of 1.27.0 the correlation between Graphs and the Map are broken. Pre 1.27.0 in the Drive Details Dashboard when you mouse over a portion of the Graph a dot would show the corresponding position on the Map.

Expected Behavior

In the Drive Details Dashboard when you mouse over a portion of the Graph a dot should show the corresponding position on the Map.

Steps To Reproduce

  1. open the Drive Details dashboard in grafana.
  2. mouse over any one of the graphs.
  3. ... you will see no correlating dot on the map.

Relevant log output

.

Screenshots

No response

Additional data

No response

Type of installation

Manual

Version

1.27.0

LelandSindt avatar Jul 17 '22 17:07 LelandSindt

https://github.com/adriankumpf/teslamate/discussions/2759

LelandSindt avatar Jul 17 '22 17:07 LelandSindt

Same issue for me as well. That's a bug on 1.27.0.?

ktsenvolt avatar Jul 17 '22 18:07 ktsenvolt

I also encountered this problem...

kktoo21 avatar Jul 18 '22 09:07 kktoo21

i have the same problem

snoof avatar Jul 18 '22 12:07 snoof

Instead of "me too" posts there is a "subscribe" button on the top right of this page which will get you notifications.

Please do comment if you are adding some useful debug info for the developers to see/use.

MrPaulAR avatar Jul 18 '22 20:07 MrPaulAR

same. docker installation.

snbdot avatar Jul 21 '22 12:07 snbdot

The timesyncing support of the TrackMap plugin only works with the deprecated Graph (old) panel in Grafana. That panel is going to be removed in future Grafana releases. In Grafana 8 it's still present but cannot be selected anymore when changing the panel type.

There is another trackmap plugin called alexandra-trackmap-panel but it does not support timesyncing either: https://github.com/alexandrainst/alexandra-trackmap-panel/issues/87

So we could either try downgrade to the old Graph panel or wait for a fix in one of the trackmap plugins.

adriankumpf avatar Jul 22 '22 10:07 adriankumpf

The timesyncing support of the TrackMap plugin only works with the deprecated Graph (old) panel in Grafana. That panel is going to be removed in future Grafana releases. In Grafana 8 is still present but cannot be selected anymore when changing the panel type.

There is another trackmap plugin called alexandra-trackmap-panel but it does not support timesyncing either: alexandrainst/alexandra-trackmap-panel#87

So we could either try downgrade to the old Graph panel or wait for a fix in one of the trackmap plugins.

if downgrade to the old Graph panel can do:

  1. dot show the corresponding position on the Map
  2. show tire pressure definitely downgrade to the old Graph panel is GREAT ideal

snbdot avatar Aug 03 '22 13:08 snbdot

So it seems that the reason to upgrade the Grafana panel is because it's going to be removed in a future version.

That's ok, but meanwhile it still works. So why not revert the change and wait until we are forced to upgrade it? That would give some time for the plugins to catch up.

sargue avatar Aug 04 '22 06:08 sargue

I agree. But how?

ktsenvolt avatar Aug 04 '22 12:08 ktsenvolt

Any chance, that the alexandra plugin will support timesyncing?

DrMichael avatar Aug 04 '22 15:08 DrMichael

Well, any instructions for downgrading the Grafana? And what was the version back then?

LiamWangjy avatar Oct 09 '22 03:10 LiamWangjy

you can use docker-compose aim grafana 1.26> Well, any instructions for downgrading the Grafana? And what was the version back then?

snbdot avatar Oct 16 '22 08:10 snbdot

you can use docker-compose aim grafana 1.26> Well, any instructions for downgrading the Grafana? And what was the version back then?

Successfully downgraded, thanks

LiamWangjy avatar Oct 18 '22 05:10 LiamWangjy

only for docker install user.

1.backup your data 2.delete teslamate (4 container) 3.edit docker-compose.xml ( line grafana lestest to 1.26) 4.reinstall ( docker-compose up -d) 5.restore data


发件人: LiamWangjy @.> 发送时间: Tuesday, October 18, 2022 1:05:41 PM 收件人: adriankumpf/teslamate @.> 抄送: snbdot @.>; Comment @.> 主题: Re: [adriankumpf/teslamate] Drive Graph/Map correlation broken. (Issue #2770)

you can use docker-compose aim grafana 1.26> Well, any instructions for downgrading the Grafana? And what was the version back then?

Successfully downgraded, thanks

― Reply to this email directly, view it on GitHubhttps://github.com/adriankumpf/teslamate/issues/2770#issuecomment-1281820089, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANJVMXMBNUU4KUGM22JVE63WDYV2LANCNFSM532BDVVQ. You are receiving this because you commented.Message ID: @.***>

snbdot avatar Oct 18 '22 05:10 snbdot

This bug has been fixed?

ironjing avatar Nov 28 '22 11:11 ironjing

This bug has been fixed?

Still waiting for a fix..

djpalmis avatar Dec 05 '22 11:12 djpalmis

This bug has been fixed?

Still waiting for a fix..

It might take a while since the issue in plugin's repo is not very active https://github.com/pR0Ps/grafana-trackmap-panel/issues/67 and the plugin itself seems to be updated for the last time on Mar 10, 2021.

CrowMash avatar Dec 14 '22 07:12 CrowMash

I've made a PR to the trackmap-panel plugin to support new hover event types of Grafana which seem to fix this issue for me: https://github.com/pR0Ps/grafana-trackmap-panel/pull/77

Hopefully the plugin gets updated and the update eventually lands into teslamate too.

pesintta avatar Dec 28 '22 20:12 pesintta

I've made a PR to the trackmap-panel plugin to support new hover event types of Grafana which seem to fix this issue for me: pR0Ps/grafana-trackmap-panel#77

Hopefully the plugin gets updated and the update eventually lands into teslamate too.

The PR has been merged, so the current master branch of the TrackMap plugin contains the fix. However, it hasn't yet been released as a new version to Grafana Labs.

Is it possible to install the plugin into Teslamate's Grafana directly from the master branch (or a defined commit hash) instead of the outdated released version?

olexs avatar Jan 07 '23 11:01 olexs

Hey all, @pesintta's fix for this issue has been released in v2.1.3 of pR0Ps/grafana-trackmap-panel and submitted to the Grafana plugin repo. Not sure when it'll be updated there but the signed plugin zip is currently available via an attachment on the GitHub release.

pR0Ps avatar Jan 11 '23 07:01 pR0Ps

@adriankumpf hi,look here. the bug has been fixed. May i trouble you update teslamate tag...

ironjing avatar Jan 11 '23 08:01 ironjing

hey, I updated the trackmap panel to v2.1.3 in 160d0a2fd44736e6108248a619c195f1c930c03e (released as v1.27.2)

adriankumpf avatar Jan 13 '23 11:01 adriankumpf