accessible-html icon indicating copy to clipboard operation
accessible-html copied to clipboard

Published 20 hours ago • verified publisher icon tesk9

Require id and controls when setting up tabs and tabpanels

Open jamesrweb opened this issue 2 years ago • 5 comments

Fixes #28.

jamesrweb avatar Sep 11 '22 00:09 jamesrweb

Thanks for the PRs! I'll take a look this week 🙏

tesk9 avatar Sep 12 '22 23:09 tesk9

@tesk9 Just added changes to attempt to autocorrect bad selected state input from users, in case you wondered what the pushes I just made were for. No more to come for this PR, just thought it could be a nice addition for review.

jamesrweb avatar Sep 13 '22 14:09 jamesrweb

Oh, I see, so you would keep the Utilities like those for Aria but not the base elements?

Perhaps the package should be renamed if you do that though because accessible-html implies an accessible version of the html package in my view.

Either way, thanks for the heads up. Will you merge this and the other PRs before the next major release then before acting on such a decision?

jamesrweb avatar Oct 29 '22 10:10 jamesrweb

@jamesrweb Yes I'll release a new major version with this code in it first!

tesk9 avatar Nov 01 '22 20:11 tesk9

Once #34 is merged, the conflicts with the latest master should be resolved.

jamesrweb avatar Feb 23 '23 14:02 jamesrweb

I think I want to move this library toward just being attribute helpers after all, sorry! I highly encourage you to take the code you wrote and make a tab component package -- I think it'll be easier to manage as an isolated package than it would be as part of accessible-html and accessible-html-with-css.

Sorry again for the incredibly slow response here.

tesk9 avatar Jun 17 '24 22:06 tesk9