tersec
tersec
> Merge branch 'status-im:stable' into epbs the development branches should generally track `unstable`, not `stable`
Are the deletions of `NimYAML`, `gnosis-chain-configs`, `nim-libbacktrace`, `nim-libp2p`, and `sepolia` vendored git subrepositories intentional? 
> > Are the deletions of `NimYAML`, `gnosis-chain-configs`, `nim-libbacktrace`, `nim-libp2p`, and `sepolia` vendored git subrepositories intentional? > >  > > Yes, they are. Not sure if I was supposed...
The CI still isn't running, partly because of the merge conflicts.  https://github.com/status-im/nimbus-eth2/pull/6443/commits/b922f277ab3c2b920a9b9e681e034752a82919d0 does add back the removed submodules, but doesn't fully address `sepolia`; if nothing else, it seems to...
CI error from https://github.com/status-im/nimbus-eth2/actions/runs/10436092895/job/28915055678?pr=6443: ``` /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/network_metadata.nim(312, 53) /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/network_metadata.nim(231, 11) loadCompileTimeNetworkMetadata /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/network_metadata.nim(231, 11) Error: config.yaml not found for network '/github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/../../vendor/sepolia/metadata make: *** [Makefile:447: wss_sim] Error 1 ``` It's because the `vendor/sepolia`...
Current CI build error from https://github.com/status-im/nimbus-eth2/actions/runs/10485514869/job/29049260286?pr=6443 ``` 2024-08-21T10:33:59.3219729Z ...................................................../github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/eth2_network.nim(26, 18) Error: cannot open file: libp2p/services/wildcardresolverservice 2024-08-21T10:33:59.4585071Z ........................./github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/eth2_network.nim(26, 18) Error: cannot open file: libp2p/services/wildcardresolverservice 2024-08-21T10:33:59.5158541Z .........make: *** [Makefile:447: mev_mock] Error 1...
Same issue after https://github.com/status-im/nimbus-eth2/pull/6443/commits/7a8f3d28671381a8c6ee8ec39c6d0bf47528029f from https://github.com/status-im/nimbus-eth2/actions/runs/10495776698/job/29095113051?pr=6443 ``` 2024-08-22T06:41:11.3486196Z ....../github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/eth2_network.nim(26, 18) Error: cannot open file: libp2p/services/wildcardresolverservice 2024-08-22T06:41:11.5353221Z make: *** [Makefile:447: mev_mock] Error 1 2024-08-22T06:41:11.5354120Z make: *** Waiting for unfinished jobs.... 2024-08-22T06:41:11.7260264Z...
https://github.com/status-im/nimbus-eth2/actions/runs/10542331340/job/29213098600?pr=6443 ``` ... 2024-08-25T05:06:54.2440825Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/epbs.nim(61, 52) Error: undeclared identifier: 'PTC_SIZE' 2024-08-25T05:06:54.2442766Z candidates (edit distance, scope distance); see '--spellSuggest': 2024-08-25T05:06:54.2443694Z (2, 3): 'csize' 2024-08-25T05:06:54.2695466Z make: *** [Makefile:647: gnosis-build] Error 1 ......
https://github.com/status-im/nimbus-eth2/actions/runs/10752309189/job/29884832856?pr=6443 ``` 2024-09-09T16:08:28.1595661Z stack trace: (most recent call last) 2024-09-09T16:08:28.1599116Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/network_metadata.nim(324, 11) network_metadata 2024-09-09T16:08:28.1602221Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/lib/std/assertions.nim(41, 14) failedAssertImpl 2024-09-09T16:08:28.1605340Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/lib/std/assertions.nim(36, 13) raiseAssert 2024-09-09T16:08:28.1607975Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/lib/system/fatal.nim(53, 5) sysFatal 2024-09-09T16:08:28.1614180Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/lib/system/fatal.nim(53, 5) Error: unhandled...
Basically I think https://github.com/status-im/nimbus-eth2/pull/6443/commits/ef50df0b4cf9a074207e6b2fb67b32aab56cec8e should be reconsidered