cache-master icon indicating copy to clipboard operation
cache-master copied to clipboard
verified publisher icon terrylinooo

Images fix and custom post type improvements

Open yannicklin opened this issue 3 years ago • 1 comments

yannicklin avatar Jul 12 '22 01:07 yannicklin

could you also add support for custom post type archives?

couldn't woocommerce handling be generalized by support for custom taxonomies and custom post types?

swiffer avatar Jul 18 '22 19:07 swiffer

Hi @swiffer may you share details ? Custom Post Type Archives?

yannicklin avatar Aug 12 '22 00:08 yannicklin

Custom Post Types can be registered with an "has_archive" boolean flag set to true.

https://developer.wordpress.org/reference/functions/register_post_type/

https://developer.wordpress.org/plugins/post-types/working-with-custom-post-types/

swiffer avatar Aug 12 '22 06:08 swiffer

@yannicklin it's working fine for me now, thanks a lot! - to ease review by @terrylinooo maybe it helps to revert the changes in the formatting? would be great to see this merged!

swiffer avatar Aug 30 '22 07:08 swiffer

That's what I'm thinking about. I wanna merge the two PRs into a new one, and ignore the changes in the formatting. Thanks @swiffer for your feedback.

yannicklin avatar Sep 02 '22 06:09 yannicklin