terreng
install location (Windows)
The installer doesn't ask for a location and puts the files in a non-standard path (C:\Users...) instead of inside Program Files.
puts the files in a non-standard path
There is no standard path for windows install locations. Traditionally they are installed in Program Files, though many many apps (eg discord, vscode, element desktop) also install in the users program files. Also see: https://superuser.com/a/1481723
allowToChangeInstallationDirectory
Right, unfortunately this is the normal/default behavior for Electron apps. But VSCode, for example, does have the option to install in Program Files with the 'System Installer' (or by running the 'User Installer' elevated). Obsidian does too.
https://stackoverflow.com/questions/60170653/electron-app-installation-to-programfiles https://github.com/electron-userland/electron-builder/issues/5871
Honestly IDK how many people want this, but I think you should get a choice. Some installers (Vivaldi browser) let you choose during installation and let you elevate later with admin credentials if necessary.
Thanks for opening this issue and #285. Both are very low priority to me, but I will consider enabling allowToChangeInstallationDirectory for the next version's nsis installer, whenever that may be. I would rather leave it off since it's less common these days for other major applications, but since this is a developer tool, I can get behind the argument that we should give users the choice.
I'm not sure how different install locations might impact #285. I don't use Windows much these days, so if you have any insight into that, please let me know.
I'm not sure how different install locations might impact #285. I don't use Windows much these days, so if you have any insight into that, please let me know.
That shouldn't be impacted at all. The installed version should retain the same absolute path for the config files (inside AppData\Roaming), regardless of where the executables are installed. That's how pretty much all installed Windows apps behave nowadays.
#285 is only about the portable version, which should store the config files relative/next to the executable files, so that you can copy the app folder and move it around (to a different computer). Often portable versions work like this "out of the box", with no user interaction. Other times, there's an additional step. An example of the latter is VSCode, which requires the creation of an empty 'data' folder next to code.exe.
Apologies if what I wrote is obvious, just making sure I'm not misunderstood. And if you're asking about any technical challenges of implementing this (with Electron...), I've no idea sorry.
Thanks for sharing this - it's very helpful. I'll leave a comment on the other issue with my thoughts.