darglint icon indicating copy to clipboard operation
darglint copied to clipboard

Add support for `pyproject.toml` for configuration

Open sgraaf opened this issue 4 years ago • 5 comments

Add support for configuration using pyproject.toml, as specified in PEP 518.

Inspired by both isort and mypy, I have resorted to the tomli package for parsing TOML files. As such, this PR introduces the first non-dev dependency to darglint.

Closes #130.

sgraaf avatar Aug 23 '21 23:08 sgraaf

Sorry for the late response; I've been handling an estate for a death in the family, and I haven't been very active with this project lately, anyway.

I'd prefer not to add any dependencies to darglint, if possible. It looks like a TOML parser will be added to the standard library in the near future, though. So, as long as the configuration is relatively simple and won't require many changes to adopt the standard library version, then I suppose it should be fine.

The tests are currently failing, though. It looks like the dependency isn't correctly installed when running the tox script. Once that's resolved, it should be good to merge.

terrencepreilly avatar Sep 10 '21 17:09 terrencepreilly

I love the concept of making tomli optional so this feature could be added. Having a single config file makes the top level repo directories so much cleaner. Thank you for the work!

raddessi avatar Nov 17 '21 22:11 raddessi

Any updates on this?

ghost avatar Dec 15 '21 09:12 ghost

Any news on this one? Love this tool and it would make it even better to be able to define the config as part of poetry :)

theNicelander avatar Sep 02 '22 12:09 theNicelander

@sgraaf @terrencepreilly Any chance to revive this?

ssbarnea avatar Dec 02 '22 13:12 ssbarnea