armi

armi copied to clipboard

Right now, when we run ARMI unit tests on GitHub Actions, we do four parallel processes: https://github.com/terrapower/armi/blob/de4eeeec280abf155f19cd709a5f32b9f899fef0/.github/workflows/unittests.yaml#L32 https://github.com/terrapower/armi/blob/de4eeeec280abf155f19cd709a5f32b9f899fef0/.github/workflows/wintests.yaml#L27 https://github.com/terrapower/armi/blob/de4eeeec280abf155f19cd709a5f32b9f899fef0/.github/workflows/coverage.yaml#L33 But is "4" the optimum number, to make the tests run...

john-science

Interface index numbering changes within a snapshot run

3

I noticed that during a snapshot run the numbering of interfaces as they are printed in the STDOUT changes between the `interactInit()` and `interactBOC()` times. Here are some pictures from...

keckler

There is an undocumented feature in ARMI: https://github.com/terrapower/armi/blob/cfc23356334253cb714171349f51acceb2db0225/armi/reactor/blocks.py#L406-L411 It would be good to write this in the user documentation, maybe in [this section about assembly blueprints](https://terrapower.github.io/armi/user/inputs.html#assemblies). Other related docstrings: https://github.com/terrapower/armi/blob/cfc23356334253cb714171349f51acceb2db0225/armi/physics/neutronics/crossSectionGroupManager.py#L1009-L1013...

keckler

Add support for hexagonal ducts with filleted corners

3

ARMI currently supports Hexagonal ducts with sharp corners, but in many practical cases the hex ducts have rounded (filleted) corners with a specified corner radius, which reduces both the flow...

dlangewisch

A typical example of using the `crossSectionControl` setting might look something like this: ```yaml crossSectionControl: GA: geometry: 0D fluxFileLocation: \\some\location LA: geometry: 1D cylinder validBlockTypes: - control blockRepresentation: ComponentAverage1DCylinder driverID:...

keckler

Writing EOC and EOL explicitly to the DB

2

## Description This PR suggests adding two new type of timesteps to write data to the ARMI DBs: one at EOC and one at EOL. So, for instance, we might...

onufer

Check on snapshot DB name is not smart

2

There is a settings validator that checks the name of the database being used in a snapshot run: https://github.com/terrapower/armi/blob/f9903fe5a5d30ceda389d6494020f7a0c0f01b92/armi/operators/settingsValidation.py#L450-L459 This check tries to ensure that the snapshot DB and the...

keckler

Update uniform mesh converter to use optimal mesh size when material boundaries cannot be honored

2

https://github.com/terrapower/armi/blob/cfc23356334253cb714171349f51acceb2db0225/armi/reactor/converters/uniformMesh.py#L192 The goal of axial mesh decusping is to honor important material boundaries in the uniform computational mesh; typically, these are the top and bottom of the fuel and absorber...

mgjarrett

Move `a/b.p.detailedNDens` to internal plugin

8

The parameter `detailedNDens` is defined for both blocks and assemblies in the framework. Here are both of those definitions: https://github.com/terrapower/armi/blob/1e356e7ee1756c4bde05eea1a9b9a8398e72c4f1/armi/reactor/assemblyParameters.py#L134-L147 https://github.com/terrapower/armi/blob/1e356e7ee1756c4bde05eea1a9b9a8398e72c4f1/armi/reactor/blockParameters.py#L51-L65 There are a couple minor issues with these parameters...

keckler

The description for `fpModelLibrary` is confusing

2

I have been tripped up by this description multiple times now. It is enough for me to assume that I'm not the only one who finds this confusing. https://github.com/terrapower/armi/blob/1e356e7ee1756c4bde05eea1a9b9a8398e72c4f1/armi/physics/neutronics/fissionProductModel/fissionProductModelSettings.py#L57-L63 In...

keckler