armi

armi copied to clipboard

## Description A ton of our functions and methods have bad return statements, I am attempting to fix those here. **NOTE**: This is a WIP, as I expect this to...

john-science

Remove point class

4

## Description This PR proposes to remove the `Point` class from the framework. The idea behind the class makes sense, but its implementation should be explored some more before releasing...

Nebbychadnezzar

Swap the ordering of the XS group manager and fuel handler in the interface stack

1

Right now the crossSectionGroupManager comes before the fuelHandler in the interface stack. This is not ideal because then whatever is eventually shuffled into the core for that cycle would not...

keckler

It appears that _anytime_ one uses the detailed cycles settings (see #637 ), a validator is raised:  This is raised even if your input does not actually contain any...

keckler

Allow users to always provide input for non-uniform assemblies in the blueprints

6

Currently, if the `detailedAxialExpansion` setting is set to `False`, the user input is for all the assemblies in the blueprints file are required to contain axial mesh points that are...

jakehader

Expose the CoordinateLocator capabilities to blueprints, and make tests

1

The `grids` system has a [CoordinateLocation](https://github.com/terrapower/armi/blob/3f834e0c10ffeef677c57ca663a2ce816a4b54f5/armi/reactor/grids.py#L491) that is used as the anchor of grids, but is intended to also allow arbitrary placement of objects at arbitrary coordinates. We need an...

ntouran

I'm curious if there should be a setting to say which assemblies to skip and we can just configure our application to neglect control rods. _Originally posted by @jakehader (and...

albeanth

Reformat `runLog.extra` in `manageCoreMesh` to use "tabulate"

4

Let's format this better. The output is pretty ugly. You could use tabulate. _Originally posted by @jakehader in https://github.com/terrapower/armi/pull/823#discussion_r943819693_

albeanth

Using the following `pylint` command, I found 40 different functions/methods in ARMI that are broken, in that they have inconsistent return statements: > pylint armi | grep "inconsistent-return-statements" This means...

john-science

Parameter mapping fix in the uniform mesh converter.

2

## Description This adds a fix to the uniform mesh converter where data was being removed from the source reactor if it was not set on the converted reactor. This...

jakehader