Either move valid settings check to specifyInputs, or address and close Issue #772

[opotowsky]

In case.py's copyInterfaceInputs, there is a check for a valid setting:

            if not isinstance(key, settings.Setting):
                try:
                    key = cs.getSetting(key)
                except NonexistentSetting(key):
                    raise ValueError(
                        f"{key} is not a valid setting. Ensure the relevant specifyInputs "
                        f"method uses a correct setting name."
                    )

This check being in copyInterfaceInputs makes it untestable. It should either get removed (which addresses Issue #772) or be moved to specifyInputs.

[john-science]

What's the status of this, after your recent copyInterfaceInputs() PR?

[opotowsky]

It's kind of because of the PR (and the testing coverage). I just wanted to make sure that there's an issue to remove it no matter what, in case the other issue was too difficult to fix.

[opotowsky]

It's on my mind, just lower priority for the moment

[john-science]

@opotowsky This ticket is still assigned to you. That's cool with me, but if you aren't planning on working on it, please un-assign it.

(You are not being singled out, I am going through all the ARMI tickets.)

[opotowsky]

Sure I'll unassign, since I can't prioritize it or the other ticket right now!