armi icon indicating copy to clipboard operation
armi copied to clipboard

Allow users to define flag names with numerical values

Open john-science opened this issue 1 year ago • 0 comments

What is the change?

Historically, ARMI Flags have been all-caps and English Alphabet only: FUEL, DUCT``, FEED`, and so on. And if you added a numerical digit into the mix, it would be ignored (for various reasons).

This PR makes it so if the user defines a parameter it will be treated as an exception to the "letters only" rule, and handled exactly as-is.

This is only meant to support "upper case letters and numbers though". This PR still does not support flag names with:

  • whitespace
  • non-English characters
  • special characters, like punctuation
  • very long names

Why is the change being made?

This was a feature request made by downstream users.


Checklist

  • [x] The release notes have been updated if necessary.
  • [x] The documentation is still up-to-date in the doc folder.
  • [x] The dependencies are still up-to-date in pyproject.toml.

john-science avatar Oct 21 '24 23:10 john-science