armi icon indicating copy to clipboard operation
armi copied to clipboard

Cleaning out unused code and adding coverage

Open john-science opened this issue 1 year ago • 1 comments

What is the change?

This is just a general cleanup PR.

  1. Removed prepSearch(), which was fully deprecated years ago, and verified that it wasn't used anywhere downstream.
  2. Removed a strange staticmethod SkippingXsGen_BuChangedLessThanTolerance, which was fundamentally unused.
  3. Fixed the interactBOL test in DB interface to stop leaving test crumbs (FINALLY, this took like a year to find).
  4. Moved two functions that were inside the FuelHandler.getAssembly() out of that function, to make them testable.
  5. Added a ton some generic code coverage.

Why is the change being made?

I just ran afoul of the deprecated function, and wanted to do some cleanup.


Checklist

  • [x] The release notes have been updated if necessary.
  • [x] The documentation is still up-to-date in the doc folder.
  • [x] The dependencies are still up-to-date in pyproject.toml.

john-science avatar Aug 29 '24 22:08 john-science

If I could make 1 request, I know you grepped around, but please run this on the testing suite for an internal TP App before merging. Thank you, @john-science !

albeanth avatar Aug 30 '24 18:08 albeanth

If I could make 1 request, I know you grepped around, but please run this on the testing suite for an internal TP App before merging. Thank you, @john-science !

I will do that, sure!

john-science avatar Aug 30 '24 21:08 john-science

@opotowsky @albeanth Okay, I tested this downstream with the usual battery of cross-platform testing. It looks good!

john-science avatar Sep 03 '24 16:09 john-science

@opotowsky @albeanth Okay, I tested this downstream with the usual battery of cross-platform testing. It looks good!

Merge away! 🚀

opotowsky avatar Sep 05 '24 18:09 opotowsky