terraform-google-vpn icon indicating copy to clipboard operation
terraform-google-vpn copied to clipboard

fix: mark secret outputs sensitive for classic vpn Ref: #158

Open qbaze opened this issue 1 year ago • 2 comments

qbaze avatar May 21 '24 10:05 qbaze

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 21 '24 10:05 google-cla[bot]

@qbaze have you tried setting these outputs sensitive in your root module code?

imrannayer avatar May 22 '24 14:05 imrannayer

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Jul 21 '24 23:07 github-actions[bot]

@imrannayer sorry for a late response

when used as a submodule it works fine but isn't it to work also as a standalone one?

are there any cons marking these sensitive in its own outputs?

qbaze avatar Jul 23 '24 10:07 qbaze

@qbaze these are published as modules. Expectation is they will be used as module.

imrannayer avatar Jul 23 '24 14:07 imrannayer

/gcbrun

imrannayer avatar Jul 23 '24 14:07 imrannayer

/gcbrun

bharathkkb avatar Jul 23 '24 16:07 bharathkkb