added logging boolean for mig healthcheck

[hjoh95]

[comment-bot-dev]

Thanks for the PR! 🚀 Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

• ⚠️check_generate_modules The modules need to be regenerated. Please run make_build.

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/mig/README.md /tmp/tmp.XgkSydCm9e/workspace/modules/mig/README.md
30c30
< | health\_check | Health check to determine whether instances are responsive and able to do work | <pre>object({<br>    type                = string<br>    initial_delay_sec   = number<br>    check_interval_sec  = number<br>    healthy_threshold   = number<br>    timeout_sec         = number<br>    unhealthy_threshold = number<br>    response            = string<br>    proxy_header        = string<br>    port                = number<br>    request             = string<br>    request_path        = string<br>    host                = string<br>    enable_logging      = bool<br>  })</pre> | <pre>{<br>  "check_interval_sec": 30,<br>  "enable_logging": false,<br>  "healthy_threshold": 1,<br>  "host": "",<br>  "initial_delay_sec": 30,<br>  "port": 80,<br>  "proxy_header": "NONE",<br>  "request": "",<br>  "request_path": "/",<br>  "response": "",<br>  "timeout_sec": 10,<br>  "type": "",<br>  "unhealthy_threshold": 5<br>}</pre> | no |
---
> | health\_check | Health check to determine whether instances are responsive and able to do work | <pre>object({<br>    type                = string<br>    initial_delay_sec   = number<br>    check_interval_sec  = number<br>    healthy_threshold   = number<br>    timeout_sec         = number<br>    unhealthy_threshold = number<br>    response            = string<br>    proxy_header        = string<br>    port                = number<br>    request             = string<br>    request_path        = string<br>    host                = string<br>  })</pre> | <pre>{<br>  "check_interval_sec": 30,<br>  "healthy_threshold": 1,<br>  "host": "",<br>  "initial_delay_sec": 30,<br>  "port": 80,<br>  "proxy_header": "NONE",<br>  "request": "",<br>  "request_path": "/",<br>  "response": "",<br>  "timeout_sec": 10,<br>  "type": "",<br>  "unhealthy_threshold": 5<br>}</pre> | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/mig/main.tf /tmp/tmp.XgkSydCm9e/workspace/modules/mig/main.tf
181,183d180
<   log_config {
<     enable = var.health_check["enable_logging"]
<   }
203,205d199
<   log_config {
<     enable = var.health_check["enable_logging"]
<   }
223,225d216
<   }
<   log_config {
<     enable = var.health_check["enable_logging"]
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/mig/variables.tf /tmp/tmp.XgkSydCm9e/workspace/modules/mig/variables.tf
118d117
<     enable_logging      = bool
133d131
<     enable_logging      = false
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

• ⚠️check_terraform Failed Terraform check. More details below.

Running terraform fmt
Running terraform validate
terraform_validate ./examples/compute_instance/disk_snapshot 
Success!
The configuration is valid.
terraform_validate ./examples/compute_instance/multiple_interfaces 
Success!
The configuration is valid.
terraform_validate ./examples/compute_instance/next_hop 
Success!
The configuration is valid.
terraform_validate ./examples/compute_instance/simple 
Success!
The configuration is valid.
terraform_validate ./examples/compute_instance/tags 
Success!
The configuration is valid.
terraform_validate ./examples/instance_template/additional_disks 
Success!
The configuration is valid.
terraform_validate ./examples/instance_template/alias_ip_range 
Success!
The configuration is valid.
terraform_validate ./examples/instance_template/encrypted_disks 
Success!
The configuration is valid.
terraform_validate ./examples/instance_template/simple 
Success!
The configuration is valid.
terraform_validate ./examples/mig/autoscaler 
Success!
The configuration is valid.
terraform_validate ./examples/mig/full 
╷
│

Error: 
Invalid value for module argument
│

│

 on main.tf line 72, in module "mig":
│

 72:   health_check = 
var.health_check
│

│

The given value is not suitable for child module variable "health_check"
│

defined at ../../../modules/mig/variables.tf:103,1-24: attribute
│

"enable_logging" is required.
╵
terraform_validate ./examples/mig/healthcheck 
Success!
The configuration is valid.
terraform_validate ./examples/mig/simple 
Success!
The configuration is valid.
terraform_validate ./examples/mig_with_percent/simple 
Success!
The configuration is valid.
terraform_validate ./examples/preemptible_and_regular_instance_templates/simple 
Success!
The configuration is valid.
terraform_validate ./examples/umig/full 
Success!
The configuration is valid.
terraform_validate ./examples/umig/named_ports 
Success!
The configuration is valid.
terraform_validate ./examples/umig/simple 
Success!
The configuration is valid.
terraform_validate ./examples/umig/static_ips 
Success!
The configuration is valid.
terraform_validate ./modules/compute_disk_snapshot 
Success!
The configuration is valid.
terraform_validate ./modules/compute_instance 
Success!
The configuration is valid.
terraform_validate ./modules/instance_template 
Success!
The configuration is valid.
terraform_validate ./modules/mig 
Success!
The configuration is valid.
terraform_validate ./modules/mig_with_percent 
Success!
The configuration is valid.
terraform_validate ./modules/preemptible_and_regular_instance_templates 
Success!
The configuration is valid.
terraform_validate ./modules/umig 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/compute_instance/disk_snapshot 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/compute_instance/simple_zone 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/instance_simple 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/instance_template/additional_disks 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/instance_template/alias_ip_range 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/instance_template/simple 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/mig/autoscaler 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/mig/healthcheck 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/mig/simple 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/mig_with_percent/simple 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/preemptible_and_regular_instance_templates/simple 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/umig/named_ports 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/umig/simple 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/fixtures/umig/static_ips 
╷
│

Warning: 
Version constraints inside provider configuration blocks are deprecated
│

│

 on network.tf line 18, in provider "random":
│

 18:   version = 
"~> 2.2"
│

│

Terraform 0.13 and earlier allowed provider version constraints inside the
│

provider configuration block, but that is now deprecated and will be
│

removed in a future version of Terraform. To silence this warning, move the
│

provider version constraint into the required_providers block.
╵
Success!
The configuration is valid, but there were some
validation warnings as shown above.
terraform_validate ./test/setup 
Success!
The configuration is valid.

[hjoh95]

Hoping to get some help here as I'm unfamiliar with using makefile. I've run make build and make generate_docs from the root /terraform-google-vm directory, which seem to complete, but no files are changed. My assumption is that the issue is because my terraform workspace (and git, make, etc) is a docker container itself, so make build is attempting to create a nested container.

I am also confused by check_terraform because I don't know where to edit the inputs to include enable_logging

[github-actions[bot]]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days