terraform-google-sql-db icon indicating copy to clipboard operation
terraform-google-sql-db copied to clipboard

feat: adding support for automatic creation of psc consumer

Open sid-occrp opened this issue 1 year ago • 1 comments

When using psc you can optionally create psc consumer for main and read replica in the specified network and subnet.

sid-occrp avatar Jul 04 '24 14:07 sid-occrp

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 04 '24 14:07 google-cla[bot]

@imrannayer @isaurabhuttam how is my PR looking ?

sid-occrp avatar Jul 22 '24 09:07 sid-occrp

/gcbrun

imrannayer avatar Jul 22 '24 15:07 imrannayer

/gcbrun

imrannayer avatar Jul 23 '24 14:07 imrannayer

@sid-occrp integration test failed

Error: "name" ("your_network_name") doesn't match regexp "^(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)$"

  with module.network-auto-psc.module.vpc.google_compute_network.network,
  on .terraform/modules/network-auto-psc/modules/vpc/main.tf line 21, in resource "google_compute_network" "network":
  21:   name                                      = var.network_name
}

imrannayer avatar Jul 23 '24 14:07 imrannayer

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Oct 08 '24 23:10 github-actions[bot]