terraform-google-sql-db icon indicating copy to clipboard operation
terraform-google-sql-db copied to clipboard

Support Query Insights for MySQL

Open thealgirdas opened this issue 3 years ago • 2 comments

Issue https://github.com/terraform-google-modules/terraform-google-sql-db/issues/347

GCP now support Query Insights for MySQL

thealgirdas avatar Oct 12 '22 08:10 thealgirdas

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 12 '22 08:10 google-cla[bot]

@bharathkkb please review when ready! This resolves https://github.com/terraform-google-modules/terraform-google-sql-db/issues/347

thealgirdas avatar Oct 20 '22 06:10 thealgirdas

@thealgirdas Would you be able to add support for the safer_mysql module? Should just require exposing the insights_config variable in safer_mysql/variables.tf and passing it to the mysql module in safer_mysql/main.tf. Otherwise I will do this in a separate PR.

alexrjones avatar Oct 24 '22 05:10 alexrjones

@thealgirdas Thanks for the PR! 🚀
✅ Lint checks have passed.

comment-bot-dev avatar Oct 26 '22 06:10 comment-bot-dev