feat!: Add `secondary_zone` to db modules

[jamiezieziula]

Closes #320

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[jamiezieziula]

@bharathkkb - can you let me know the failure here - I can't see details of that cloud build run

[reynaldo-rack]

Good catch @jamiezieziula!

Sorry @bharathkkb do you have any update on this?

I am getting drift because of this...

Terraform will perform the following actions:

  # module.sql-db.google_sql_database_instance.default will be updated in-place
  ~ resource "google_sql_database_instance" "default" {
        id                            = "mysqldb-13ae63bd"
        name                          = "mysqldb-13ae63bd"
        # (11 unchanged attributes hidden)

      ~ settings {
            # (10 unchanged attributes hidden)

          ~ location_preference {
              - secondary_zone = "us-central1-a" -> null
                # (1 unchanged attribute hidden)
            }

            # (4 unchanged blocks hidden)
        }

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

[czka]

The secondary_zone support added by @jamiezieziula's in this PR (thanks!) works fine with my PostgreSQL instance. The PR seems complete to me.

@bharathkkb what's stopping us from merging this? Looks like the Google Cloud Build CI step is broken?

[jamiezieziula]

@bharathkkb any update here?

[jamiezieziula]

@bharathkkb please let me know what I can do to move this along

[comment-bot-dev]

@jamiezieziula Thanks for the PR! 🚀
✅ Lint checks have passed.