terraform-google-network icon indicating copy to clipboard operation
terraform-google-network copied to clipboard

fix: Document firewall and subnets properties

Open yuryninog opened this issue 2 years ago • 1 comments

Complete the description of the properties: firewall_rules subnets routes Reported in this issue: https://github.com/terraform-google-modules/terraform-google-network/issues/379

yuryninog avatar Oct 10 '22 23:10 yuryninog

@yuryninog Thanks for the PR! 🚀 Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

  • ⚠️check_documentation The documentation needs to be regenerated. Please run make generate_docs.
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/README.md /tmp/tmp.br5FKKBT24/generate_docs/workspace/README.md
105c105
< | firewall\_rules | List of firewall rules | `any` | `[]` | no |
---
> | firewall\_rules | List of maps that represent the firewall rules to be created. Each firewall rule is represented using a map that should contains this data: name, direction, priority, description, ranges, source\_tags, source\_service\_accounts, target\_tags, target\_service\_accounts, allow, deny, log\_config | `any` | `[]` | no |
113c113
< | subnets | The list of subnets being created | `list(map(string))` | n/a | yes |
---
> | subnets | The list of subnets being created | `list(map(any))` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/modules/subnets/README.md /tmp/tmp.br5FKKBT24/generate_docs/workspace/modules/subnets/README.md
68c68
< | subnets | The list of subnets being created | `list(map(string))` | n/a | yes |
---
> | subnets | The list of subnets being created | `list(map(any))` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/modules/subnets-beta/README.md /tmp/tmp.br5FKKBT24/generate_docs/workspace/modules/subnets-beta/README.md
75c75
< | subnets | The list of subnets being created | `list(map(string))` | n/a | yes |
---
> | subnets | The list of subnets being created | `list(map(any))` | n/a | yes |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

comment-bot-dev avatar Nov 07 '22 21:11 comment-bot-dev

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Jan 06 '23 23:01 github-actions[bot]