terraform-google-lb-http icon indicating copy to clipboard operation
terraform-google-lb-http copied to clipboard

feat: allow customizing resource name with prefix & suffix

Open BapRx opened this issue 10 months ago • 7 comments

Hello @bharathkkb,

I'm submitting this PR to revive the issue #268 to allow custom name, very useful when we're dealing with resource imports!

I used the optional variables as mentioned in the linked issue. I added both prefix and suffix options while keeping the existing values as default. Let me know what you think, I can make adjustments if needed.

I tested the module with existing code without noticing regressions.

BapRx avatar Apr 23 '24 16:04 BapRx

@BapRx ca u plz update templates and follow contribution guide?

imrannayer avatar Apr 23 '24 16:04 imrannayer

@BapRx ca u plz update templates and follow contribution guide?

I updated the templates, sorry about that

BapRx avatar Apr 23 '24 17:04 BapRx

/gcbrun

imrannayer avatar Apr 30 '24 18:04 imrannayer

Hello @g-awmalik could you please take a look at this PR? thanks

BapRx avatar May 29 '24 08:05 BapRx

/gcbrun

g-awmalik avatar Jul 12 '24 19:07 g-awmalik

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Sep 10 '24 23:09 github-actions[bot]

not stale

BapRx avatar Sep 11 '24 10:09 BapRx