terraform-google-lb-http icon indicating copy to clipboard operation
terraform-google-lb-http copied to clipboard

Serverless_negs module: Quic - No option to disable HTTP/3 advertising

Open sakthivel-pro opened this issue 2 years ago • 2 comments

TL;DR

With the recent communication from GCP, quicOverride=NONE mode will advertise support for HTTP/3 to our clients. Providing Terraform config quic = false is updated as quicOverride=NONE. Deadline for the rollout is March 21, 2022.

A new option is required to disable HTTP/3 advertisement or by default quic = false should disable the HTTP/3 mode. Possibly change the data type from boolean to string to support different options.

https://cloud.google.com/load-balancing/docs/https#configuring-http3

Screenshot 2022-03-14 at 7 17 42 PM

Expected behavior

No response

Observed behavior

No response

Terraform Configuration

quic = false

Doesn't change it to quicOverride=DISABLED.



### Terraform Version

Terraform v0.14.3
+ provider registry.terraform.io/hashicorp/google v3.90.1
+ provider registry.terraform.io/hashicorp/google-beta v3.90.1

Your version of Terraform is out of date! The latest version
is 1.1.7. You can update by downloading from https://www.terraform.io/downloads.html


### Additional information

_No response_

sakthivel-pro avatar Mar 14 '22 14:03 sakthivel-pro

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar May 14 '22 23:05 github-actions[bot]

@sakthivel-tw Happy to review a PR updating this.

bharathkkb avatar May 24 '22 15:05 bharathkkb

@sakthivel-tw Setting quic = false should send null value. Provider default value is None which is equivalent of DISABLE. Can you plz confirm if this is working fine?

imrannayer avatar Apr 10 '23 16:04 imrannayer

@imrannayer The Provider default value NONE is acting as the same as ENABLE. (I can confirm on my project HTTP/3 is advertized when set to NONE) https://cloud.google.com/load-balancing/docs/https#configuring-http3 image

I think making false map to DISABLE will retain the original behaviour prior to March 21, 2022

s3i7h avatar Apr 12 '23 11:04 s3i7h

Apprarently the provider hasn't updated the description yet to match the actual behaviour https://github.com/hashicorp/terraform-provider-google-beta/blob/acc18edf88435e6f42081622dd0991e6102c31de/google-beta/resource_compute_target_https_proxy.go#L90-L92

s3i7h avatar Apr 12 '23 12:04 s3i7h

@yu-ichiro can you plz create an issue for provider to update the doc?

[quic_override](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_target_https_proxy#quic_override) - (Optional) Specifies the QUIC override policy for this resource. This determines whether the load balancer will attempt to negotiate QUIC with clients or not. Can specify one of NONE, ENABLE, or DISABLE. If NONE is specified, uses the QUIC policy with no user overrides, which is equivalent to DISABLE. Default value is NONE. Possible values are: NONE, ENABLE, DISABLE.

imrannayer avatar Apr 12 '23 13:04 imrannayer

@yu-ichiro nm. Just noticed you already created issue #14287

imrannayer avatar Apr 12 '23 13:04 imrannayer