terraform-google-kubernetes-engine

terraform-google-kubernetes-engine copied to clipboard

(possibly) unneeded/unused `resource null_resource.module_depends_on` created

1

### TL;DR A _possibly_ unneeded/unused resource is created when calling the module and _it's the only one_ created as part of that module call (`enabled = false` because defaults are...

swapzero

Set zones for cluster_autoscaling

2

When using the cluster_autoscaling, the node_pool get auto created only when the default node_pool exists. If the default node_pool is created and then deleted with cluster creation, the node auto-provisioning...

ericdong2014

Question: Is there a reason to not delete the default node pool by default?

3

Is there a specific reason why the `remove_default_node_pool` variable is set to `false` by default? Given that the `default-node-pool` node pool is set up by default, it seems to me...

rux616

Move master_global_access_enabled to private-cluster

3

It's not beta anymore.

MikeMichel

initial_node_count value not getting updated from terraform

3

### TL;DR Whenever we try to update initial_node_count variable, terrafrom plan and apply did not show any changes ### Expected behavior initial_node_count must be updated through terraform ### Observed behavior...

RITESHBRID

Using exisiting gcp sa and k8s sa the null object command to anontate fails.

6

### TL;DR When attempting to use this module with and existing SA's the module's null object command for kubectl anontate fails the command succeeds on the command line. Claim annotate...

xophere

Use map type for labels in modules/hub

1

### TL;DR All other resource types and TF modules I've run across for GCP use a map type when defining labels. Instead, the 'hub' submodule appears to require a comma...

justicel

`intra-egress` firewall rule depends on `google_container_cluster.primary`

6

### Summary The [intra-cluster egress firewall rule](https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/14a0536bbcfeb89dc1af21f8fef0cb46affdc52e/autogen/main/firewall.tf.tmpl#L24-L65) appears to depend on `google_container_cluster.primary`. This means it will not be created until _after_ the default node pool is created and deleted. If...

tomasgareau

Allow setting network tags on default node pool

1

I'm trying to bring up a [`safer-cluster`](https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/master/modules/safer-cluster) in a Shared VPC network roughly based on the [`terraform-example-foundation/3-networks`](https://github.com/terraform-google-modules/terraform-example-foundation/tree/master/3-networks) approach. In this VPC network, access to private Google APIs is configured with:...

tomasgareau

Inconsistent conditional result types in kubernetes-engine_workload-identity output

3

### TL;DR Terraform chokes with `Error: Inconsistent conditional result types` when trying to compute `gcp_service_account` output in `workload-identity/output.tf`. ### Expected behavior _No response_ ### Observed behavior The full error message...

psarka