terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

Kubernetes Provider v2 Support

Open Harjot1Singh opened this issue 3 years ago • 7 comments

Hi!

Any plans to support the new 2.x Kubernetes provider?

The upgrade path doesn't look too bad: https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/guides/v2-upgrade-guide.

Harjot1Singh avatar Feb 08 '21 19:02 Harjot1Singh

Hi @Harjot1Singh

Happy to review a PR with the update.

bharathkkb avatar Feb 08 '21 21:02 bharathkkb

Brilliant! Would you like me to version bump the module in the PR? Or will you cut the release separately?

Harjot1Singh avatar Feb 08 '21 22:02 Harjot1Singh

Curious if there has been any progress on this in the last ~2 months. The provider is still locked at 1.x: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/9de43d749dbdf595daae469c7061f1264d385940/versions.tf#L26-L28

lhriley avatar Apr 01 '21 19:04 lhriley

No progress as it's still on our backlog, but we'd be happy to review a PR.

morgante avatar Apr 05 '21 20:04 morgante

Unfortunately, I don't have the bandwidth to tackle all of the testing required before submitting a PR for this, or I would be more than happy to write something up.

lhriley avatar Apr 08 '21 20:04 lhriley

I did fork and make the change to get the bare minimum running here: https://github.com/Harjot1Singh/terraform-google-kubernetes-engine

Haven't run it against the test criteria, but if https://github.com/Harjot1Singh/terraform-google-kubernetes-engine/commit/768d5b674f76c2491aac3ebddcfb381fd78fbc35 looks suitable then can PR it in. For other folks trying to get this to work meanwhile, set source = "github.com/Harjot1Singh/terraform-google-kubernetes-engine"

Harjot1Singh avatar Apr 17 '21 15:04 Harjot1Singh

@Harjot1Singh Thanks, those look to be along the lines of what we'd need but note the updates need to be made in autogen/ first.

morgante avatar Apr 19 '21 11:04 morgante