terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

feat: adds local_nvme_ssd_block_config to beta-public-cluster

Open florianMalbranque opened this issue 1 year ago • 2 comments

florianMalbranque avatar Mar 23 '24 09:03 florianMalbranque

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 23 '24 09:03 google-cla[bot]

@gtsorbo , @ericyz , @Jberlinsky would you please take a look ?

florianMalbranque avatar Mar 23 '24 09:03 florianMalbranque

/gcbrun

apeabody avatar Mar 25 '24 15:03 apeabody

@apeabody, would you be able to trigger CI again and give your approval please ?

florianMalbranque avatar Apr 03 '24 07:04 florianMalbranque

/gcbrun

(re-trigger, quota)

apeabody avatar Apr 03 '24 15:04 apeabody

had to rebase again, @apeabody would you be able to trigger ci run again please ?

@gtsorbo , @ericyz , @Jberlinsky <ould you be able to approve please ?

florianMalbranque avatar Apr 04 '24 10:04 florianMalbranque

/gcbrun

apeabody avatar Apr 04 '24 15:04 apeabody

Thanks for your review @apeabody, it should be good now

florianMalbranque avatar Apr 08 '24 11:04 florianMalbranque

/gcbrun

apeabody avatar Apr 08 '24 15:04 apeabody

Hi @florianMalbranque - Looks like we need a quick make build, thanks!

apeabody avatar Apr 08 '24 15:04 apeabody

Woops 🤦 , @apeabody make build executed and committed ✔️

florianMalbranque avatar Apr 08 '24 16:04 florianMalbranque

/gcbrun

apeabody avatar Apr 08 '24 16:04 apeabody

Thanks again for your reviews @apeabody ! it should be good now, PTAL

florianMalbranque avatar Apr 12 '24 06:04 florianMalbranque

/gcbrun

apeabody avatar Apr 12 '24 15:04 apeabody