terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

chore(docs): Add NOTE to direct ASM users using GKEHub TF Module

Open wonjekang opened this issue 1 year ago • 4 comments

Currently, ASM Submodule is not supported / managed anymore by ASM team. Highly recommending customers using GKEHub TF module to install ASM.

wonjekang avatar Mar 11 '24 23:03 wonjekang

@bharathkkb I think adding this context in the migration guide is a good idea. Do we have a timeline to have it? However, we still have ASM customers depend on this ASM submodule and we cannot remove it at this time. Let's keep this change at this time.

wonjekang avatar Mar 14 '24 16:03 wonjekang

I think adding this context in the migration guide is a good idea. Do we have a timeline to have it?

If we are recommending to switch to the new resources, co-locating the migration guide in the PR would be good. Otherwise let's make it a fast follow.

We still have ASM customers depend on this ASM submodule and we cannot remove it at this time. Let's keep this change at this time.

Even if we remove the module, users can still use continue to use released versions. Only new module releases will not have this submodule.

bharathkkb avatar Mar 15 '24 01:03 bharathkkb

@bharathkkb Could you share the instruction to write the migration guide? I don't have any context where I can start from. IIUC, your recommendation in this PR is:

  1. Remove the ASM submodule package.
  2. Add the context to use gkehub resources for ASM installation in migration guide document(?)

wonjekang avatar Mar 15 '24 17:03 wonjekang

@wonjekang Yeah for 1 and 2. Example guides are in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/master/docs and next major version would be 31. Here is a previous ASM example https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/docs/upgrading_to_v20.0.md#upgrading-to-v200

bharathkkb avatar Apr 04 '24 22:04 bharathkkb