terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

feat: add network tags to auto-provisioned node pools

Open MyMirelHub opened this issue 1 year ago • 8 comments

MyMirelHub avatar Jan 11 '24 14:01 MyMirelHub

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 11 '24 14:01 google-cla[bot]

Thanks for the PR @MyMirelHub. Can you please sign the CLA while I review this?

g-awmalik avatar Jan 17 '24 18:01 g-awmalik

/gcbrun

g-awmalik avatar Jan 17 '24 18:01 g-awmalik

@MyMirelHub - are you still working on this PR? If not, can you flip its status?

g-awmalik avatar Jan 21 '24 05:01 g-awmalik

@g-awmalik ready for review

MyMirelHub avatar Jan 26 '24 11:01 MyMirelHub

@MyMirelHub - can you please rebase this with master since I'm unable to do it for you.

g-awmalik avatar Feb 12 '24 16:02 g-awmalik

/gcbrun

MyMirelHub avatar Feb 12 '24 16:02 MyMirelHub

Please rebase again.

g-awmalik avatar Feb 20 '24 19:02 g-awmalik

/gcbrun

MyMirelHub avatar Apr 02 '24 08:04 MyMirelHub

fixed by #1920

MyMirelHub avatar Apr 03 '24 18:04 MyMirelHub