Enable managed prometheus disables cloud monitoring in v28

[szihai]

TL;DR

Shouldn't that be left as default value "System"?

Expected behavior

Shouldn't that be left as default value "System"?

Observed behavior

In v27, when managed prometheus is enabled, the cloud monitoring value was left as default: Now in v28, the cloud monitoring is disabled: Our configuration did not change. Also when checking with GCP documentation, the default value should still be "System".

Please fix this issue.

Terraform Configuration

module "gke" {
  source  = "terraform-google-modules/kubernetes-engine/google//modules/beta-private-cluster"
  version = "~> 28.0.0"

  ...

  #managed prometheus
  monitoring_enable_managed_prometheus = var.monitoring_enable_managed_prometheus
  ...
}

variable "monitoring_enable_managed_prometheus" {
  type        = bool
  description = "Configuration for Managed Service for Prometheus. Whether or not the managed collection is enabled."
  default     = true
}

Terraform Version

Terraform v1.6.1
on linux_amd64

Additional information

No response

[szihai]

I tested on the commit 2beb7207. Disregard the setting of "monitoring_enable_managed_prometheus", Terraform plan only wants to disable cloud monitoring: Which means the release candidate for v29.0.0 has not fixed this issue.

[szihai]

I just tried with v29.0.0, the problem is still there. It disables cloud monitoring when enables prometheus.

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[m3adow]

This issue is still a problem (together with most other GMP issues).

[bergemalm]

Still an issue!

[m0ps]

It's not really an issue. The fix is pretty simple: define monitoring_enabled_components variable.

Source: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/issues/1706#issuecomment-1810686466

[m3adow]

It's not really an issue. The fix is pretty simple: define monitoring_enabled_components variable.

Source: #1706 (comment)

Sadly that's not an option for some cluster variants, as they don't (yet?) support monitoring_enabled_components: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/issues/1793

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days